[Privoxy-devel] OK to move the winsetup dir under current?

[Lee]

On 8/16/17, Fabian Keil <fk at fabiankeil.de> wrote:
> Lee <ler762 at gmail.com> wrote:
>
>> I'm updating the 'how to build on windows' documentation & it would
>> make things much easier on the windows side if the winsetup/ directory
>> was under current/ instead of being at the same level.
>>
>> 1. It would be included in the source tarball at release time
>> 2. It would get tagged with the version number at release time
>> 3. No extra gymnastics required for doing a release build on windows
>>
>> Anyone have a problem if I move it under current?
>
> Yes.
>
> winsetup contains an nsis binary without corresponding source code.
>
> While the nsis license seems to allow this, I do not want to indirectly
> sign binaries I didn't create myself and I don't think we should distribute
> binaries as part of the source tarball anyway.

Yes - good point.

> It would also create problems for downstream projects with policies
> that prevent them from distributing binaries they didn't create
> themselves and that currently redistribute the source tarball as is.
>
> I wouldn't object to the GPLv2-licensed source code and icons in
> winsetup being moved over to current, though, as there don't seem
> to be a lot of files compared to the windows-specific files that are
> already there.
>
> Of course this wouldn't reduce the gymnastics required to
> build a windows release with installer.

What if nsis.exe becomes just another program that the user is
responsible for downloading/installing - ie. the same deal as sed,
awk, perl, gcc, etc.

I dunno how much emphasis is placed on backwards compatibility by the
nsis group, so we keep the current winsetup/nsis around for the
official win32 builds and tell users they can download the nsis
executable from us or the official project site (with a note about
possible compatibility issues?)

The existing winsetup/
  GNUmakefile
  privoxy.ico
  privoxy_winthreads.nsi
  readme.txt   (changes TBD)
  uninstall_privoxy.ico
gets moved to a new current/win32 directory and the appropriate
adjustments are made to current/win32/GNUmakefile to
  set the correct source dir (SOURCE   = ../)
  set MAKENSIS if not already set & check the program exists ( -x $MAKENSIS ???)

Which seems a bit cleaner & doesn't use any clear-text protocols :)

Lee