[Privoxy-devel] OK to move the winsetup dir under current?

[Fabian Keil]

Lee <ler762 at gmail.com> wrote:

> I'm updating the 'how to build on windows' documentation & it would
> make things much easier on the windows side if the winsetup/ directory
> was under current/ instead of being at the same level.
> 
> 1. It would be included in the source tarball at release time
> 2. It would get tagged with the version number at release time
> 3. No extra gymnastics required for doing a release build on windows
> 
> Anyone have a problem if I move it under current?

Yes.

winsetup contains an nsis binary without corresponding source code.

While the nsis license seems to allow this, I do not want to indirectly
sign binaries I didn't create myself and I don't think we should distribute
binaries as part of the source tarball anyway.

It would also create problems for downstream projects with policies
that prevent them from distributing binaries they didn't create
themselves and that currently redistribute the source tarball as is.

I wouldn't object to the GPLv2-licensed source code and icons in
winsetup being moved over to current, though, as there don't seem
to be a lot of files compared to the windows-specific files that are
already there.

Of course this wouldn't reduce the gymnastics required to
build a windows release with installer.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20170816/e7609dda/attachment.bin>