[Privoxy-devel] OK to move the winsetup dir under current?

[Fabian Keil]

Lee <ler762 at gmail.com> wrote:

> On 8/16/17, Fabian Keil <fk at fabiankeil.de> wrote:

> > I wouldn't object to the GPLv2-licensed source code and icons in
> > winsetup being moved over to current, though, as there don't seem
> > to be a lot of files compared to the windows-specific files that are
> > already there.
> >
> > Of course this wouldn't reduce the gymnastics required to
> > build a windows release with installer.  
> 
> What if nsis.exe becomes just another program that the user is
> responsible for downloading/installing - ie. the same deal as sed,
> awk, perl, gcc, etc.

Sounds good to me.

> I dunno how much emphasis is placed on backwards compatibility by the
> nsis group, so we keep the current winsetup/nsis around for the
> official win32 builds and tell users they can download the nsis
> executable from us or the official project site (with a note about
> possible compatibility issues?)

If the binary (or another version that works) is still available
from the official project site, it seems sufficient to me to document
this and mention the version and checksum of the file that was used
to create the Privoxy release builds.

> The existing winsetup/
>   GNUmakefile
>   privoxy.ico
>   privoxy_winthreads.nsi
>   readme.txt   (changes TBD)
>   uninstall_privoxy.ico
> gets moved to a new current/win32 directory and the appropriate
> adjustments are made to current/win32/GNUmakefile to
>   set the correct source dir (SOURCE   = ../)
>   set MAKENSIS if not already set & check the program exists ( -x $MAKENSIS ???)

Sounds good to me. It should probably be done after the git migration,
though, so the history isn't lost.

I intent to request the missing preferred git ids in the next
couple of days and finally migrate the current repository in
September.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20170828/4a8df9cc/attachment.bin>