[Privoxy-users] privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition

[Fabian Keil]

David Binderman <dcb314 at hotmail.com> wrote on 2021-02-02:

> Some static analysis has produced this message:
> 
> privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition
> (assignment + comparison); Clarify expression with parentheses.
> [clarifyCondition]
[...]
> Maybe better code
> 
>                      || ((len = ssl_flush_socket(&(csp->ssl_client_attr),
>                             csp->iob)) < 0))

Thanks for the report. I added the parentheses:
https://www.privoxy.org/gitweb/?p=privoxy.git;a=commitdiff;h=1735db35cf6e78e892535418accc59f23c335881

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-users/attachments/20210203/0b1add8a/attachment.bin>