[Privoxy-users] privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition

[David Binderman]

Hello there,

Some static analysis has produced this message:

privoxy-3.0.31-stable/jcc.c:3944:25: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

Source code is

                     || (len = ssl_flush_socket(&(csp->ssl_client_attr),
                            csp->iob) < 0))
                  {

Maybe better code

                     || ((len = ssl_flush_socket(&(csp->ssl_client_attr),
                            csp->iob)) < 0))
                  {

Regards

David Binderman