[Privoxy-devel] PATCH for pcre2 support

[Fabian Keil]

Fabian Keil <fk at fabiankeil.de> wrote on 2023-06-18 at 11:12:55:

> Gagan Sidhu <broly at mac.com> wrote on 2023-06-17 at 06:40:29:
> 
> > anyways. let’s get this bad boy rolled into the tree.
> > i’m delighted to hear everything is operational and we finally have pcre2 for privoxy!
> 
> Unfortunately it looks like there are a couple of issues left:
[...]
> ==71261== 40,016 (38,960 direct, 1,056 indirect) bytes in 487 blocks are definitely lost in loss record 29 of 29
> ==71261==    at 0x484CBC4: malloc (in /usr/local/libexec/valgrind/vgpreload_memcheck-amd64-freebsd.so)
> ==71261==    by 0x4BD3C0D: ??? (in /usr/local/lib/libpcre2-8.so.0.11.2)
> ==71261==    by 0x4BBC3D9: pcre2_jit_compile_8 (in /usr/local/lib/libpcre2-8.so.0.11.2)
> ==71261==    by 0x275608: pcrs_compile (pcrs.c:709)
> ==71261==    by 0x2753FE: pcrs_compile_command (pcrs.c:602)
> ==71261==    by 0x267589: load_one_re_filterfile (loaders.c:1320)
> ==71261==    by 0x266DBD: load_re_filterfiles (loaders.c:1068)
> ==71261==    by 0x267896: run_loader (loaders.c:1439)
> ==71261==    by 0x2645CA: load_config (loadcfg.c:2199)
> ==71261==    by 0x254DBD: listen_loop (jcc.c:6214)
> ==71261==    by 0x254B53: main (jcc.c:6011)

The attached patch seems to fix this.

Another issue left is:

==64176== Invalid read of size 16
==64176==    at 0x6A49CC4: ???
==64176==    by 0x60B895F: ???
==64176==  Address 0x60ba5cf is 7,279 bytes inside a block of size 7,287 alloc'd
==64176==    at 0x484CBC4: malloc (in /usr/local/libexec/valgrind/vgpreload_memcheck-amd64-freebsd.so)
==64176==    by 0x276682: pcrs_execute (pcrs.c:973)
==64176==    by 0x24E714: pcrs_filter_impl (filters.c:1656)
==64176==    by 0x24E2D1: pcrs_filter_response_body (filters.c:1768)
==64176==    by 0x24BB07: execute_content_filters (filters.c:2561)
==64176==    by 0x2597F6: handle_established_connection (jcc.c:3597)
==64176==    by 0x25774C: chat (jcc.c:4870)
==64176==    by 0x255785: serve (jcc.c:5056)
==64176==    by 0x4CD5A79: ??? (in /lib/libthr.so.3)

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pcrs_free_job-Free-using-pcre2_code_free-when-using-.patch
Type: text/x-patch
Size: 1650 bytes
Desc: not available
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230619/a71a2c06/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230619/a71a2c06/attachment-0001.bin>