[Privoxy-devel] privoxy 3.0.27 regression test fail

[Roland Rosenfeld]

Hi Fabian!

On So, 30 Dez 2018, Fabian Keil wrote:

> Lee <ler762 at gmail.com> wrote:
> 
> > It's been a while since I've run the regression tests; I didn't used
> > to get this:
> > 2018-12-29 19:54:40: Ooops. We expected status code 200, but received: 403.
> > 2018-12-29 19:54:40: Failure for test 573. URL 'http://p.p/toggle' and
> > expected status code '200'
> > 
> > If I change enable-remote-toggle to 1 all tests pass, but normally
> > I've got it set to 0
> 
> The test was out of date. This should be fixed in git now.

For me this still doesn't work as expected.
If I set "enable-edit-actions 0" in the config file, the tests
enable-edit-actions test are skipped and the result is okay.

But if I set "enable-edit-actions 1" in the config file, I still run
into the issue mentioned by Lee.

I can also reproduce this issue with my production
system. http://config.privoxy.org/show-status tells me that
 enable-edit-actions 1
but http://p.p/edit-actions gives "Privoxy Configuration access
denied", while I read the following in the log file:
"Error: Denying access to http://p.p/edit-actions. No referrer found."

So the missing referrer seems to be the root cause here.

Digging some deeper shows me, that the referer header seems not to be
activated in privoxy-regression-test, enforcing it via 
 $curl_parameters .= '--referer ' . quote(PRIVOXY_CGI_URL) . ' ';
in execute_dumb_fetch_test() changes the behavior to:
 Ooops. We expected status code 200, but received: 302.
since p.p redirects to config.privoxy.org.

So there seem to be some in the regression test code.

To get 3.0.28 out of the door, I'll temporarily set
"enable-edit-actions 0" the get the Debian package out of the door,
but I fear that the regression test mechanism need some love (next
year ;-)


Happy New Year!
Roland
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20181231/beb92ef4/attachment.bin>