[Privoxy-devel] privoxy-3.0.27-stable bug report

[David Binderman]

Hello there,

privoxy-3.0.27-stable/jcc.c:2525]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

                  if (write_socket_delayed(csp->cfd, hdr, hdrlen, write_delay)
                   || ((flushed = flush_iob(csp->cfd, csp->iob, write_delay) < 0)
                   || (write_socket_delayed(csp->cfd, csp->receive_buffer,
                         (size_t)len, write_delay))))
                  {

Maybe better code

                  if (write_socket_delayed(csp->cfd, hdr, hdrlen, write_delay)
                   || ((flushed = flush_iob(csp->cfd, csp->iob, write_delay)) < 0
                   || (write_socket_delayed(csp->cfd, csp->receive_buffer,
                         (size_t)len, write_delay))))
                  {

Regards

David Binderman