[Privoxy-commits] [privoxy] 06/19: change_request_destination(): Reject rewrites from http to https

[User Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository privoxy.

commit c0def7e7a0e43f3a907e96391937817e8912d230
Author: Fabian Keil <fk at fabiankeil.de>
AuthorDate: Thu Jan 7 14:41:17 2021 +0100

    change_request_destination(): Reject rewrites from http to https
    
    ... as they currently aren't supported.
    
    Previously we would wait for the client to establish
    an encrypted connection which obviously would not happen.
---
 jcc.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/jcc.c b/jcc.c
index a5e561f5..4b85fe70 100644
--- a/jcc.c
+++ b/jcc.c
@@ -1044,6 +1044,16 @@ static jb_err change_request_destination(struct client_state *csp)
       log_error(LOG_LEVEL_ERROR, "Couldn't parse rewritten request: %s.",
          jb_err_to_string(err));
    }
+   if (http->ssl && strcmpic(csp->http->gpc, "CONNECT"))
+   {
+      /*
+       * A client header filter changed the request URL from
+       * http:// to https:// which we currently don't support.
+       */
+      log_error(LOG_LEVEL_ERROR, "Changing the request destination from http "
+         "to https behind the client's back currently isn't supported.");
+      return JB_ERR_PARSE;
+   }
 
    return err;
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.