[Privoxy-devel] Test failures delaying the 4.0.0 release

[Fabian Keil]

Roland Rosenfeld <roland at spinnaker.de> wrote on 2025-01-12 at 17:40:01:

> On Sun, 12 Jan 2025, Fabian Keil via Privoxy-devel wrote:
> 
> > On my system acl-destination-denied is now the only failing scenario.
> 
> And what's about acl-ip-address-denied, does this work for you without
> changing the return value from 56 to 52?

As it turns out it works on my development system:

fk at t520 ~/git/privoxy/tests/cts $./run-privoxy-tests.sh -t acl-ip-address-denied
Test scenario: acl-ip-address-denied
Overwriting default TESTDIR with /home/fk/git/privoxy/tests/cts/acl-ip-address-denied/data
********* System characteristics ******** 
* curl 7.85.0-DEV (amd64-unknown-freebsd14.2) 
* libcurl/7.85.0-DEV OpenSSL/3.0.15 zlib/1.3.1 libidn2/2.3.7 libpsl/0.21.5 (+libidn2/2.3.7) nghttp2/1.64.0
* Features: alt-svc AsynchDNS Debug HSTS HTTP2 HTTPS-proxy IDN IPv6 Largefile libz NTLM NTLM_WB PSL SSL threadsafe TLS-SRP TrackMemory UnixSockets
* Disabled: 
* Host: t520.local
* System: ElectroBSD t520.local 14.2-STABLE ElectroBSD 14.2-STABLE #49 electrobsd-14-n270357-5e1b07e1e6c2: 2025-01-07 14:31:47 +0000     fk at t520.local:/usr/obj/usr/src/amd64.amd64/sys/ELECTRO_BEER amd64
* OS: freebsd
*
*** DISABLES memory tracking when using threaded resolver
*
* Servers: SSL HTTP-IPv6 HTTP-unix FTP-IPv6 
* Env: 
* Seed: 262633
***************************************** 
test 0001...[Request from denied IP address]
-------e--- OK (1   out of 1  , remaining: 00:00, took 0.043s, duration: 00:00)
TESTDONE: 1 tests were considered during 0 seconds.
TESTDONE: 1 tests out of 1 reported OK: 100%

But still fails on a test system:

fk at test-vm ~/git/privoxy/tests/cts $./run-privoxy-tests.sh -t acl-ip-address-denied
Test scenario: acl-ip-address-denied
Overwriting default TESTDIR with /home/fk/git/privoxy/tests/cts/acl-ip-address-denied/data
********* System characteristics ******** 
* curl 7.85.0-DEV (amd64-unknown-freebsd14.2) 
* libcurl/7.85.0-DEV OpenSSL/3.0.15 zlib/1.3.1
* Features: alt-svc AsynchDNS Debug HSTS HTTPS-proxy IPv6 Largefile libz NTLM NTLM_WB SSL threadsafe TLS-SRP TrackMemory UnixSockets
* Disabled: 
* Host: test-vm
* System: FreeBSD test-vm 14.2-STABLE ElectroBSD 14.2-STABLE #0: Tue Dec 31 13:16:10 UTC 2024     elektropunker at ElectroBSD-20241231-f500004c12e1:/usr/obj/usr/src/amd64.amd64/sys/ELECTRO_BLOAT amd64
* OS: freebsd
*
*** DISABLES memory tracking when using threaded resolver
*
* Servers: SSL HTTP-IPv6 HTTP-unix FTP-IPv6 
* Env: 
* Seed: 207549
***************************************** 
test 0001...[Request from denied IP address]

curl returned 52, when expecting 56
 exit FAILED

 - abort tests
TESTDONE: 1 tests were considered during 0 seconds.
TESTDONE: 0 tests out of 1 reported OK: 0%

TESTFAIL: These test cases failed: 1

> > > I'm currently running "make test" on curl (without privoxy) to check,
> > > whether test389 works as expected (I don't understand why
> > > curlmachine.locahost should ever work).
> 
> > On my systems hostnames ending in .localhost resolve to 127.0.0.1 and ::1.
> 
> On my system this isn't the case.  I first had to install
> systemd-resolved and point DNS to 127.0.0.53 instead of using the
> locally installed bind on 127.0.0.1.
> 
> If I activate this change, test389 runs okay in privoxy
> upstream-tests, otherwise it fails.
> 
> But it's irritating, that the curl testsuite (without privoxy)
> succeeds in test389 without the change.  Maybe curl has some resolver
> library included, that resolves curlmachine.localhost to 127.0.0.1,
> whithout asking the resolver defined in /etc/resolv.conf?
> Just tried out, this seems to be the case.
> When I run
>  curl http://curlmachine.localhost
> there is no request in the bind log ("host curlmachine.localhost"
> shows one).
> 
> Surprisingly also
>  ping curlmachine.localhost
> works (and pings ::1) and doesn't log in bind log.
> So there seems to be some voodoo in DNS resolution that works for curl
> and ping but not for privoxy...
> 
> Anyway, I can work around this issue by changing my resolver to
> resolve curlmachine.localhost, but the difference of the behavior of
> curl and privoxy is strange.

I'll probably disable the test for the release as we shouldn't
expect test users to mess with their DNS configuration.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20250112/9549dbe0/attachment-0001.bin>