[Privoxy-devel] [PATCH] Remove ./ prefix from tarball-dist files

[Ian Silvester]

Fine with me.

Happy new year to you all!

Ian

On Mon, 1 Jan 2024, at 11:57, Roland Rosenfeld wrote:
> Hi and Happy New Year!
>
> Current tarball releases always contain an useless "./" in the path
> of all files like this:
>
> privoxy-3.0.34-stable/./acconfig.h
> privoxy-3.0.34-stable/./actionlist.h
> privoxy-3.0.34-stable/./actions.c
> ...
>
> This is a little annoying when packaging privoxy in Debian, since the
> debian/copyright file contains a machine readable list of files and
> their copyright and I currently have to prefix all filenames with "./"
> because they are otherwise not found when checking the original
> tarball.  On the other hand this fails when using git or an unpacked
> file tree (where the "./" disappears).
>
> So I'd suggest to remove this (in my eyes) superfluous prefix from the
> dist tarball.  I assume that the "./" is a result of using "find .",
> which prefixes all files with "./" automatically and nobody except me
> had a problem with this before, so everybody is just ignoring the
> behavior.
>
> Are you okay with the following patch, which removes the "./" using
> sed in GNUmakefile.in.  As far as I can see, this should just work.
> It would be great if we could apply this before the next release.
>
> Greetings
> Roland
>
> diff --git a/GNUmakefile.in b/GNUmakefile.in
> index 9476426c..50f581a1 100644
> --- a/GNUmakefile.in
> +++ b/GNUmakefile.in
> @@ -440,7 +440,7 @@ tarball-dist: dist-check clean clobber
>  	for i in `find . -type f -a -not \( -path "*/CVS*" -o -name ".*" \
>  	-o -path "*/debian/*" -o -path "*/actions/*" -o -name "*.php" -o \
>  	-name "PACKAGERS" -o -path "*.git/*" \
> -	-o -path "*/doc/webserver/feeds*" \) | sort`; do \
> +	-o -path "*/doc/webserver/feeds*" \) | sort | sed 's/^\.\///'`; do \
>  	   files="$$files privoxy-$(VERSION)-$(CODE_STATUS)/$$i"; \
>  	done &&  \
>  	cd .. && $(TAR) -cvhf privoxy-$(VERSION)-$(CODE_STATUS)-src.tar $$files ; \
> _______________________________________________
> Privoxy-devel mailing list
> Privoxy-devel at lists.privoxy.org
> https://lists.privoxy.org/mailman/listinfo/privoxy-devel