[Privoxy-devel] PATCH for pcre2 support

Fabian Keil fk at fabiankeil.de
Sat Mar 11 10:55:59 CET 2023


Gagan Sidhu <broly at mac.com> wrote on 2023-03-09 at 08:49:52:

> sorry about this (lol), but upon further analysis i totally didn’t need the pcre2_matches_dummy variable.
> 
> i didn’t pay enough attention to the fact that outputs was originally declared with size PCRS_MAX_SUBMATCHES.
> 
> so if i declare pcre2_matches to this size, then no reallocation is necessary at all because these are the *submatches*.
> 	-and only the *matches* structure should grow. 
> 
> in any case, since PCRS_MAX_MATCH_INIT >PCRS_MAX_SUBMATCHES, this may have not caused any problems at all (40 > 33).
> 
> i also added a pcre2_jit_compile call that some say is equivalent to pcre2_study.
> 
> by calling pcre2_match on the pcre2_code variable that has been compiled with pcre2_jit, we should get jit capability (if available).
> 
> new sha256 is : 
> 
> 3986178a0dd241c18ef61297c4a1f48252033610921bc80dfa4d8f5bb0035117

I tried the latest version:

fk at t520 ~/git/privoxy $sha256 substandard_pcre2.patch 
SHA256 (substandard_pcre2.patch) = 142f99e4b685fee8c6592ea47a89cc4ea29622744458e70d3ae1f370abd9df27

and the CGI pages are still empty.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230311/536d66a4/attachment.bin>


More information about the Privoxy-devel mailing list