[Privoxy-devel] PATCH for pcre2 support

[Fabian Keil]

Fabian Keil <fk at fabiankeil.de> wrote on 2023-06-19 at 11:30:31:

> Fabian Keil <fk at fabiankeil.de> wrote on 2023-06-19 at 09:20:17:
> 
> > Gagan Sidhu <broly at mac.com> wrote on 2023-06-18 at 08:44:35:
> > 
> > > test 17, i assume? since after i ran the program with your change, i had one failed test:
> > 
> > No it's test 383:
> > 
> > (gdb) where
> > #0  kill () at kill.S:4
> > #1  0x00000008008926e0 in __fail (msg=0x80079c824 "stack overflow detected; terminated") at /usr/src/lib/libc/secure/stack_protector.c:130
> > #2  0x0000000800892650 in __stack_chk_fail () at /usr/src/lib/libc/secure/stack_protector.c:137
> > #3  0x000000000024abed in rewrite_url (old_url=0x80246d000 "http://go.eniro.dk/lg/ni/http:/eas8.emediate.eu/eas?camp=79;ty=ct;EASLink=http://www.bt.dk?http://redirect.metropol.dk/cgi-bin/redir.pl?url=www.bt.dk", 
> >     pcrs_command=0x801cac140 "s at .*url=@http://@") at filters.c:1038
> > #4  0x000000000024acf7 in redirect_url (csp=0x800ef2c08) at filters.c:1257
> > #5  0x00000000002583b5 in crunch_response_triggered (csp=0x800ef2c08, crunchers=0x218920 <crunchers_all>) at jcc.c:953
> > #6  0x00000000002568bb in chat (csp=0x800ef2c08) at jcc.c:4438
> > #7  0x0000000000255736 in serve (csp=0x800ef2c08) at jcc.c:5056
> > #8  0x000000080073ca7a in thread_start (curthread=0x800e13c00) at /usr/src/lib/libthr/thread/thr_create.c:292
> > #9  0x0000000000000000 in ?? ()
> > Backtrace stopped: Cannot access memory at address 0x7fffdf9fb000
> 
> The attached patch seems to fix this. (It will not cleanly apply
> to your tree as I made other changes in the region in previous
> commits).

I'm not seeing different crashes like this one, though:

#0  0x0000000823c95acd in ?? () from /usr/local/lib/libpcre2-8.so.0
[Current thread is 1 (LWP 108957)]
(gdb) where
#0  0x0000000823c95acd in ?? () from /usr/local/lib/libpcre2-8.so.0
#1  0x0000000823c9002a in pcre2_match_8 () from /usr/local/lib/libpcre2-8.so.0
#2  0x00000008255e60fe in pcre2_regexec () from /usr/local/lib/libpcre2-posix.so.3
#3  0x000000000027309b in path_matches (path=0x856e3c040 "/iomm/latest/bootstrap/stub.js", pattern=0x82a2c5f20) at urlmatch.c:1360
#4  0x0000000000272e7e in url_match (pattern=0x82a2c5f20, http=0x835520a58) at urlmatch.c:1387
#5  0x000000000024cfa8 in apply_url_actions (action=0x835520810, http=0x835520a58, client_tags=0x835520ba0, b=0x82a2c5f20) at filters.c:2884
#6  0x000000000024cf11 in get_url_actions (csp=0x835520808, http=0x835520a58) at filters.c:2845
#7  0x00000000002580ac in process_encrypted_request_headers (csp=0x835520808) at jcc.c:2799
#8  0x0000000000256a03 in chat (csp=0x835520808) at jcc.c:4472
#9  0x0000000000255796 in serve (csp=0x835520808) at jcc.c:5056
#10 0x0000000825a07a7a in thread_start (curthread=0x8355a6000) at /usr/src/lib/libthr/thread/thr_create.c:292
#11 0x0000000000000000 in ?? ()
Backtrace stopped: Cannot access memory at address 0x843d01000

I haven't been able to reproduce this yet.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230619/05e8e7a1/attachment.bin>