[Privoxy-devel] PATCH for pcre2 support

[Fabian Keil]

Gagan Sidhu <broly at mac.com> wrote on 2023-06-18 at 08:44:35:

> test 17, i assume? since after i ran the program with your change, i had one failed test:

No it's test 383:

(gdb) where
#0  kill () at kill.S:4
#1  0x00000008008926e0 in __fail (msg=0x80079c824 "stack overflow detected; terminated") at /usr/src/lib/libc/secure/stack_protector.c:130
#2  0x0000000800892650 in __stack_chk_fail () at /usr/src/lib/libc/secure/stack_protector.c:137
#3  0x000000000024abed in rewrite_url (old_url=0x80246d000 "http://go.eniro.dk/lg/ni/http:/eas8.emediate.eu/eas?camp=79;ty=ct;EASLink=http://www.bt.dk?http://redirect.metropol.dk/cgi-bin/redir.pl?url=www.bt.dk", 
    pcrs_command=0x801cac140 "s at .*url=@http://@") at filters.c:1038
#4  0x000000000024acf7 in redirect_url (csp=0x800ef2c08) at filters.c:1257
#5  0x00000000002583b5 in crunch_response_triggered (csp=0x800ef2c08, crunchers=0x218920 <crunchers_all>) at jcc.c:953
#6  0x00000000002568bb in chat (csp=0x800ef2c08) at jcc.c:4438
#7  0x0000000000255736 in serve (csp=0x800ef2c08) at jcc.c:5056
#8  0x000000080073ca7a in thread_start (curthread=0x800e13c00) at /usr/src/lib/libthr/thread/thr_create.c:292
#9  0x0000000000000000 in ?? ()
Backtrace stopped: Cannot access memory at address 0x7fffdf9fb000

> i added the lines you have given below after 
> 
> > # Blocked URL = https://ups.xplosion.de/ctx?event_id=ctx_json&_sid=24141&hostSiteUrl=https://www.presseportal.de/blaulicht/pm/12415/5302821&referrer=&userAgent=Mozilla/5.0%20(X11;%20FreeBSD%20amd64;%20rv:91.0)%20Gecko/20100101%20Firefox/91.0&userLang=en-CA&gdpr=1&gdpr_consent=[...]
> > ups.xplosion.de/
> > 
> 
> in default.action.
> 
> i still only get one error:
> 
> > GagansMacPro:privoxy Gagan$ tools/privoxy-regression-test.pl --max-level 108
> > 2023-06-18 08:42:29: Asking Privoxy for the number of action files available ...
> > 2023-06-18 08:42:29: Gathering regression tests from 3 action file(s) delivered by Privoxy 3.0.35.
> > 2023-06-18 08:42:30: Executing regression tests ...
> > 2023-06-18 08:42:32: Failure for test 70. Supposedly-blocked URL: 'https://elsa.memoinsights.com/t?pid=62012a7a19351c07620394e0&url=https%3A%2F%2Farstechnica.com%2Ftech-policy%2F2022%2F08%2Fthe-women-calling-out-apples-handling-of-misconduct-claims%2F&author%5B%5D=Financial%20Times&title=The%20women%20calling%20out%20Apple%E2%80%99s%20handling%20of%20misconduct%20claims&date=2022-08-04T13%3A39%3A42Z&referrer=&ref_url=&page_url=https%3A%2F%2Farstechnica.com%2Ftech-policy%2F2022%2F08%2Fthe-women-calling-out-apples-handling-of-misconduct-claims%2F%3Fcomments%3D1&cb=MEMO.API.callbacks.cbakynzcplf&v=v3.0.6&t=5000&e=5000&s=7362'
> > 2023-06-18 08:42:43: Executed 464 regression tests. Skipped 5. 463 successes, 1 failures.

That test passes on my system.

It also should be executed without "--max-level 108".
 
> i would like to see this link you’ve given below fail, so we’re
> consistent. but i should share that i am still getting the one error
> (whereas you had none) on the default set of tests.
> 
> i’ll try my best to look into this but i am not sure if the failed
> test is reflecting the overflow ?

On my system "-fstack-protector-all" is needed to reproduce the crash.
Without it the redirect tests pass.
 
Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230619/090a663c/attachment.bin>