[Privoxy-devel] PCRE2 for privoxy on windows

[Fabian Keil]

Lee <ler762 at protonmail.com> wrote on 2023-07-22 at 22:22:38:

> Hi all,

Hi Lee,

it's good to hear from you again.

I noticed you're using a protonmail.com email address now
so I hope this messages is accepted.

I'm CC'ing you anyway as I'm not sure whether or not you're
subscribed to the list yet.
 
> Sourceforge mail gets through to gmail which is why I noticed the
> Optional pcre2 support is available in the git master branch now.
> 
> I got it working on Windows :)

Great.

> I dunno about
> #warning The win32 build of Privoxy is expected to crash when compiled
> with pcre2 support.

I added the warning based on the assumption that the crashes
seen on ElectroBSD and on Gagan's system with the POSIX regex
functions [0] are platform independent.

My suspicion was that the crashes are the result of a bug
in pcre2 but I didn't have time to track this down or ask
the upstream.

> The only crashes I had were using OpenSSL for +https-inspection
> I do not understand what's going on there, but adding a
> #include <openssl/applink.c>
> in openssl.c fixes the problem. ... or at least I haven't had any more
> crashes.

Did you get a backtrace you could post to the list?
Did you use OpenSSL 3.x or an older release?

In general adding a header seems acceptable to me
but I'd like to understand why it helps.

> Running the regression test gets me
> 2023-07-22 17:55:52: Executed 752 regression tests. Skipped 66. 752
> successes, 0 failures.
> 
> so that looks promising :)

Please try with the --forks option. On my ElectroBSD system
"--forks 1" was already sufficient to reliable trigger the
crashes.

> See attached for my changes

I'd be interested to review you're changes in "git format-patch"
format. Can you send them to the list using a new thread for
each patch (set)?

Thanks.

Fabian

[0] <https://lists.privoxy.org/pipermail/privoxy-devel/2023-June/000664.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230724/4f7cd8c5/attachment.bin>