[Privoxy-devel] 0004-Enable-building-Privoxy-with-OpenSSL

[Fabian Keil]

Lee <ler762 at protonmail.com> wrote on 2023-08-12 at 16:26:47:

> On Thursday, August 10th, 2023 at 2:39 PM, Fabian Keil wrote:
> 
> > Lee wrote on 2023-08-09 at 07:37:00:
> > 
> > > On Wednesday, August 9th, 2023 at 5:19 AM, Fabian Keil wrote:
> > > 
> > > > The patch looks reasonable to me, but please split it
> > > > in two using one for the changes to openssl.c and project.h
> > > > and one for the change to windows/MYconfigure.
> > > 
> > > OK.. but are the changes to openssl.c and/or project.h necessary for
> > > anything besides Windows? I don't mind splitting it into two patches
> > > - I'd just like to understand the reasoning.
> > 
> > 
> > In general, I prefer small commits as I consider them
> > easier to review and more convenient when bisecting in
> > case of regressions.
> > 
> > Looking at your commit 96a448cdd70b I now think it could
> > even have been split in two again, one commit with the
> > changes to project.h which I assume where required
> > to get this to build (in which case this could have
> > been mentioned in the commit message) and another one
> > with the change to openssl.c to prevent the "crashes".
> 
> Yes, that one was kind of border-line.  On the one hand, it was what I
> had to do to get openssl working..  and on the other fixing the crashes
> could have been a separate commit.  But privoxy not working for more
> than ~45 minutes at a time is hardly "working" in my book, so one patch
> seemed more correct.

Let's agree to disagree. Now it's too late anyway ...

> > I think a line like "windows: Fix the build with OpenSSL"
> > would be more appropriate as leading line for commit 96a448cdd.
> 
> at least in my mind "fix" means to repair something & I don't think
> privoxy ever worked with openssl on windows..

I never tested it on Windows, so you're probably right.
 
> > In general I try to produce good commit messages myself
> 
> that's a talent.  I have lots of room for improvement there :(

Me too.

> > but of course I'm not perfect either and, for example,
> > regret that I didn't add another paragraph or two for
> > 53748ca8ca.
> > 
> > Probably the developer manual should contain a couple
> > of example commit messages ...
> 
> It would help

I'll add it to the TODO list.

> > I'm not saying that it can't be legally done but OpenSSL
> > is not a system library on Windows so linking to it isn't
> > covered by this "special exception" in the GPLv2:
> > 
> > | However, as a
> > | special exception, the source code distributed need not include
> > | anything that is normally distributed (in either source or binary
> > | form) with the major components (compiler, kernel, and so on) of the
> > | operating system on which the executable runs, unless that component
> > | itself accompanies the executable.
> > 
> > Therefore, in my opinion, a Privoxy binary for Windows that is linked
> > to and distributed with an OpenSSL library under the Apache 2 license
> > has to be distributed under the GPLv3 or later instead of GPLv2 or
> > later.
> 
> I was hoping that since I haven't distributed anything with OpenSSL that
> I'd be OK... In any case, I'm fine with building Privoxy for
> distribution with whatever TLS library you prefer.

Great.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230816/420dcb40/attachment.bin>