[Privoxy-devel] 0004-Enable-building-Privoxy-with-OpenSSL

[Fabian Keil]

Lee <ler762 at protonmail.com> wrote on 2023-08-03 at 15:39:58:

> Empty Message

The patch looks reasonable to me, but please split it
in two using one for the changes to openssl.c and project.h
and one for the change to windows/MYconfigure.

What is the motivation behind the patch? Did you measure
better performance than with MbedTLS (which would not surprise
me giving my own benchmarks at [0])? If yes, you may want
to mention it in the commit message.

One issue I see with the patch is that using an external
Apache2-licensed library like OpenSSL 3.x requires the
Privoxy binary to be distributed under GPLv3 (or later)
instead of GPLv2 or later so the win32_blurb[] in win32.c
may need a modification before the next release so we don't
mislead our users.

However I intend to commit the WolfSSL support before the
next release so we could use it on Windows instead of OpenSSL.

Fabian

[0]: <https://www.fabiankeil.de/gehacktes/privoxy-tls-benchmarks/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20230809/4623af13/attachment.bin>