[Privoxy-devel] 0003-fix-maybe-uninitialized-compiler-warnings

[Lee]

Empty Message
-------------- next part --------------
From ca153ee3f6ac93b9933d792d0a24f7c733cddb31 Mon Sep 17 00:00:00 2001
From: Lee <ler762 at users.sourceforge.net>
Date: Sun, 30 Jul 2023 02:16:08 -0400
Subject: [PATCH 3/9] fix maybe-uninitialized compiler warnings in filters.c
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

filters.c: In function ‘match_sockaddr’:
filters.c:205:42: warning: ‘address_port’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  205 |    if (*netmask_port && *network_port != *address_port)
      |                                          ^~~~~~~~~~~~~
filters.c:214:24: warning: ‘address_addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  214 |           (address_addr[i] & netmask_addr[i]))
      |            ~~~~~~~~~~~~^~~
filters.c:205:8: warning: ‘netmask_port’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  205 |    if (*netmask_port && *network_port != *address_port)
      |        ^~~~~~~~~~~~~
filters.c:200:20: warning: ‘netmask_addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  200 |       netmask_addr += 12;
      |                    ^~
filters.c:205:25: warning: ‘network_port’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  205 |    if (*netmask_port && *network_port != *address_port)
      |                         ^~~~~~~~~~~~~
filters.c:172:17: warning: ‘addr_len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  172 |    unsigned int addr_len;
      |                 ^~~~~~~~
filters.c: In function ‘acl_addr’:
filters.c:465:31: warning: ‘addr_len’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  465 |    for (i = 0; (i < addr_len) && masklength; i++)
      |                ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
filters.c:454:18: warning: ‘mask_port’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  454 |       *mask_port = 1;
      |       ~~~~~~~~~~~^~~
filters.c:479:19: warning: ‘mask_data’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  479 |          mask_data[i] = (uint8_t)~((1 << (8 - masklength)) - 1);
      |                   ^
---
 filters.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/filters.c b/filters.c
index 35c8476f..96ea366f 100644
--- a/filters.c
+++ b/filters.c
@@ -168,9 +168,9 @@ static int match_sockaddr(const struct sockaddr_storage *network,
                           const struct sockaddr_storage *netmask,
                           const struct sockaddr_storage *address)
 {
-   uint8_t *network_addr, *netmask_addr, *address_addr;
-   unsigned int addr_len;
-   in_port_t *network_port, *netmask_port, *address_port;
+   uint8_t *network_addr=0, *netmask_addr=0, *address_addr=0;
+   unsigned int addr_len=0;
+   in_port_t *network_port=0, *netmask_port=0, *address_port=0;
    int i;
 
    if (network->ss_family != netmask->ss_family)
@@ -325,9 +325,9 @@ int acl_addr(const char *aspec, struct access_control_addr *aca)
    int i, masklength;
 #ifdef HAVE_RFC2553
    struct addrinfo hints, *result;
-   uint8_t *mask_data;
-   in_port_t *mask_port;
-   unsigned int addr_len;
+   uint8_t *mask_data=0;
+   in_port_t *mask_port=0;
+   unsigned int addr_len=0;
 #else
    long port;
 #endif /* def HAVE_RFC2553 */
-- 
2.39.0