[Privoxy-devel] PATCH for pcre2 support

[Gagan Sidhu]

hi fabian,

thanks for bringing this to my attention. i did not include the change made in cgi.c because i wasn’t sure if it was “right”.

however i have uploaded the patch with this change just now. 

it has an sha256sum of:

8fb1cccf72bd0908ae97e2670a2eca78f4f113dc0fcd284fd39200687aecf34a

i have applied and tested it, and it now results in 17 errors when the regression tests are run, with 17 skipped.

no idea why that number has grown. but take a look and let me know.

it may be the case that how privoxy handles urls may need to be changed slightly to accommodate for pcre2.

Thanks,
Gagan

> On Apr 8, 2023, at 5:50 AM, Fabian Keil <fk at fabiankeil.de> wrote:
> 
> Gagan Sidhu <broly at mac.com> wrote on 2023-03-19 at 12:26:19:
> 
>> i tried a simple ‘fix’ by introducing an additional size_t variable and the result is much better, but not identical.
>> 
>> 13 errors on the regression test.
>> 
>> either way. this is much much much better than before.
>> 
>> i defer to your expertise to produce the final solution, which i think my findings will greatly assist in producing.
> 
> Unfortunately I can't reproduce your results.
> 
> With:
> 
> fk at t520 ~/git/privoxy $sha256 substandard_pcre2.patch
> SHA256 (substandard_pcre2.patch) = 9ed41077f6d0c59b73ca1655bdc00f825049077c5bcd3879c6f0e967a3c2a163
> 
> I still get empty CGI pages and thus can't execute the regression tests:
> 
> fk at t520 ~ $privoxy-regression-test.pl 
> 2023-04-08 13:47:06: Asking Privoxy for the number of action files available ...
> 2023-04-08 13:47:06: Gathering regression tests from 0 action file(s) delivered by Privoxy (Unknown version!).
> 2023-04-08 13:47:06: No regression tests found.
> 
> Fabian