[Privoxy-devel] Privoxy 3.0.31 windows upload

[Fabian Keil]

Lee <ler762 at gmail.com> wrote on 2021-02-18:

> On 2/16/21, Fabian Keil <fk at fabiankeil.de> wrote:
> > Fabian Keil <fk at fabiankeil.de> wrote on 2021-01-31:
> >
> >> Lee <ler762 at gmail.com> wrote on 2021-01-31:
> >>
> >> > Windows files uploaded to sourceforge.  Hopefully this is enough to
> >> > explain the difference between 3.0.31 and 3.0.31-X:
> >> >
> >> > Privoxy 3.0.31-X has the experimental https inspection feature
> >> > enabled which allows filtering https traffic.  Configure the
> >> > directives in section 7 of the config file and then add the
> >> > +https-inspection action.
> >>
> >> I think it is enough. Thanks.
> >
> > Lee, could you please document how you built the 3.0.31-X packages?
> 
> Sorry about that.  I got totally sidetracked on formatting <screen>
> output.. What do you think of standardizing on two leading spaces in
> screen and programlisting output -- ie. add this in ldp.dsp
> 
> (define %indent-programlisting-lines%
>   ;; Indent lines in a 'ProgramListing'?
>   ;; "#f" or string to be used as the indent on 'programlisting'
>   "  ")
> 
> (define %indent-screen-lines%
>   ;; Indent lines in a 'Screen'?
>   ;; "#f" or string to be used as the indent on 'screen'
>   "  ")

I have no objections to standardising on two leading spaces but
ldp.dsp seems to be generated by configure.

Did you already figure out where to add the proposed changes
so they make it into the generated file?

> Which, at least with cygwin, causes a stack overflow processing this
> bit in user-manual.sgml
>   <screen><![ RCDATA [ &GPLv2; ]]></screen>

This doesn't seem to be an issue on ElectroBSD.
 
> workaround is
> @@ -8065,11 +8066,11 @@ Requests</title>
>  <sect2 id="license"><title>License</title>
> 
>  <sect3 id="gplv2"><title>GNU General Public License version 2</title>
> - <screen><![ RCDATA [ &GPLv2; ]]></screen>
> + <literallayout class="Monospaced"><![ RCDATA [ &GPLv2;
> ]]></literallayout> </sect3>
> 
>  <sect3 id="gplv3"><title>GNU General Public License version 3</title>
> - <screen><![ RCDATA [ &GPLv3; ]]></screen>
> + <literallayout class="Monospaced"><![ RCDATA [ &GPLv3;
> ]]></literallayout> </sect3>

That seems acceptable to me.

> > By the way, do you have any objections to removing the obsolete pcre
> > code before the next release?
> 
> How about the release after next?

Okay.

> I'd rather play it safe and do one release with the built-in pcre code
> disabled, but easily re-enabled.  Something like
>   exit 1
> added after the line
>   AC_MSG_WARN([You are using the static PCRE code which is out of date
> and scheduled for removal, for details see:
>     https://sourceforge.net/p/ijbswa/mailman/ijbswa-developers/thread/20080511195555.2dc6cfdc@fabiankeil.de/])
> 
> in configure.in so anyone else building privoxy on windows will be put
> on notice that the out of date code _really is_ going to be removed.

I think adding another warning that mentions that the removal is scheduled
before the 3.0.33 release will do.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20210219/fb9b88b1/attachment.bin>