[Privoxy-devel] max-client-connections

[Fabian Keil]

Lee <ler762 at gmail.com> wrote on 2021-04-07:

> Windows updates seem to take way too long for me, so I had the privoxy
> log window open while doing an update and noticed lots of
>   Error: Rejecting connection from 127.0.0.1. Maximum number of
> connections reached.
> 
> I don't know what was going on, and it seems to have stopped before I
> changed max-client-connections from 256 to 512, but who is going to
> notice that log message as long as it's at the LOG_LEVEL_CONNECT
> level?  I almost never have
>   debug     2
> set.  So I'd like to change the log level to ERROR for everybody
>       if ((0 != config->max_client_connections)
>          && (active_threads >= config->max_client_connections))
>       {
>          log_error(LOG_LEVEL_CONNECT,      /* <------------- this to
> LOG_LEVEL_ERROR */
>             "Rejecting connection from %s. Maximum number of
> connections reached.",
>             csp->ip_addr_str);

That seems reasonable to me. 

> And the documentation for max-client-connections seems wrong:

I agree. Looks like a failed to update it when the default limit
was introduced.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20210409/f23febd4/attachment.bin>