[Privoxy-devel] https-inspection challenges

[Fabian Keil]

Lee <ler762 at gmail.com> wrote:

> On 6/7/20, Fabian Keil <fk at fabiankeil.de> wrote:
> > Lee <ler762 at gmail.com> wrote:
[...]
> >> How do I tell privoxy configure where the mbed-tls libraries/includes
> >> are located?
> >
> > On ElectroBSD I set LDFLAGS and CPPFLAGS before calling configure:
> >
> >     export LDFLAGS=-L/usr/local/lib
> >     export CPPFLAGS=-I/usr/local/include/
[...]
> make dies on me at
> i686-w64-mingw32-gcc -c -pipe -O2 -fstack-protector-strong
> -march=native -Wall -Wshadow -DWINVER=0x501
> -I/source/mbedtls-2.16.6/include  -mwindows -Wall -Imbedtls/include
> -Ipcre  ssl.c -o ssl.o
> In file included from
> /usr/i686-w64-mingw32/sys-root/mingw/include/ws2tcpip.h:17:0,
>                  from project.h:82,
>                  from ssl.c:48:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:15:2: warning:
> #warning Please include winsock2.h before windows.h [-Wcpp]
>  #warning Please include winsock2.h before windows.h
>   ^~~~~~~
> ssl.c: In function ‘generate_certificate_valid_date’:
> ssl.c:1343:2: error: #error HTTP inspection currently requires
> gmtime_r() which seems to be missing
>  #error HTTP inspection currently requires gmtime_r() which seems to be missing
>   ^~~~~
> ssl.c:1345:16: warning: implicit declaration of function ‘gmtime_r’;
> did you mean ‘gmtime_s’? [-Wimplicit-function-declaration]
>     if (NULL == gmtime_r(&time_spec, &valid_date))
>                 ^~~~~~~~
>                 gmtime_s
> ssl.c:1345:13: warning: comparison between pointer and integer
>     if (NULL == gmtime_r(&time_spec, &valid_date))
>              ^~
> make: *** [GNUmakefile:309: ssl.o] Error 1

Please try the attached patch.

I haven't properly tested it yet, but we use similar code
in parsers.c.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-generate_certificate_valid_date-Fall-back-to-using-g.patch
Type: text/x-patch
Size: 1588 bytes
Desc: not available
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20200607/7a3f1442/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20200607/7a3f1442/attachment-0001.bin>