[Privoxy-devel] any interest in a faster way to check blacklists?

[Fabian Keil]

Lee <ler762 at gmail.com> wrote:

> I use various host file blacklists to generate action files & I try to
> keep the number of duplicates down..  So I crank the new list of
> hostnames thru http://config.privoxy.org/show-url-info to see if it's
> already blocked or not
> 
> The problem is that it takes a while to check every hostname, so I
> came up with a faster way
> https://github.com/ler762/privoxy/commit/ff0bf9b850d539bbf037ff8616412bf99b5a1d2c
> 
> tl;dr: about 90 seconds vs. 197 seconds to check the lightswitch05 hosts
> file
> 
> Any interest in including the patch?

I think with a few modifications the patch would be nice to have.

actions.c
+  *      no, i have no idea what the diff is between single & multi actions

Multi actions can be applied multiple times (example filter{}) while
single actions overrule each other (example block{}). Now you know
and the comment can be removed.

It concerns me that the patch only seems to deal with single actions
as this makes the output misleading. Are multi actions really that
expensive to compute?

cgisimple.c
+   /*
+    *  make sure config files are current
+    */
+   if (run_loader(csp)) {

The curly brace is on the wrong line.

The -LR- markers can probably be removed as well.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.privoxy.org/pipermail/privoxy-devel/attachments/20200131/a22e55d1/attachment.bin>