[Privoxy-devel] Documentation problems (was: privoxy debian patches)

[Lee]

On 10/29/18, Fabian Keil <fk at fabiankeil.de> wrote:
> Lee <ler762 at gmail.com> wrote:
>
>> On 10/16/18, Roland Rosenfeld <roland at spinnaker.de> wrote:
>
>> > - Replace 06_8bit_manual.patch by a new patch, that only changes
>> >   preserve-sdata to #t in the HTML section.
>> > - Append --preserve-entities yes to TIDY options in GNUmakefile.in.
>> > - Change all ISO-8859-1 chars in doc/source/p-authors.sgml to SGML
>> >   entities
>>
>> I can make all those changes in git
>
> Documentation building is now somewhat differently broken on my system.
>
> Links contain plain &'s instead of entities:
>
> diff --git a/doc/webserver/developer-manual/git.html
> b/doc/webserver/developer-manual/git.html
> index 9efdbdcf..8ce1276c 100644
> --- a/doc/webserver/developer-manual/git.html
> +++ b/doc/webserver/developer-manual/git.html
> @@ -78,8 +78,8 @@
>          </li>
>          <li>
>            <p>Note that near a major public release, we get more cautious.
> There is always the possibility to submit a
> -          patch to the <a
> href="https://sourceforge.net/tracker/?atid=311118&group_id=11118&func=browse"
> -          target="_top">patch tracker</a> instead.</p>
> +          patch to the <a
> href="https://sourceforge.net/tracker/?atid=311118&group_id=11118&func=browse"
> target=
> +          "_top">patch tracker</a> instead.</p>
>          </li>
>        </ul>
>      </div>
>

Can you try doing a 'make clean && make distclean' before rebuilding
the docs -- without 'make dok-tidy' ?

I'm still doing all dev work on windows10/cygwin but I've got debian
working on a laptop and both systems generate
><P
>            Note that near a major public release, we get more cautious.
            There is always the possibility to submit a patch to the <A
HREF="https://sourceforge.net/tracker/?atid=311118&group_id=11118&func=browse"
TARGET="_top"
>patch
            tracker</A
> instead.
          </P

If you still get unescaped &s in urls .. I'm not sure what we need to
compare to figure out the difference.

> Additionally pre tags use incorrect spacing:
  <.. snip ..>
> The latter is actual an old problem but I'm surprised
> that it doesn't seem to happen when you build the docs.

That problem has been fixed:
  https://github.com/htacg/tidy-html5/issues/697

I forgot that I'm using a test version of tidy:
$ tidy --version
HTML Tidy for Cygwin version 5.7.16.ler762.issue-752

I'm not sure if they're going to release a new version of tidy any
time soon tho :(

Lee