[Privoxy-devel] tidy -indent -wrap can break <pre> formatting

Lee ler762 at gmail.com
Thu Mar 15 02:57:10 UTC 2018


On 3/14/18, Fabian Keil <fk at fabiankeil.de> wrote:
> Lee <ler762 at gmail.com> wrote:
>
>> On 3/14/18, Fabian Keil <fk at fabiankeil.de> wrote:
>> > Lee <ler762 at gmail.com> wrote:
>
>> >> and then what to do with all the generated html files?
>> >
>> > Commit and push them to master as well.
>>
>> That's a log of pushing.  Just to be sure,  you want me to push all this:
>
> Yes.

Just how much manual editing did you do to the generated .html files?
And do you want me to manually fix the .html files before pushing?

for example, doc/webserver/developer-manual/newrelease.html still
needs a lot of changes to fix [what i'm guessing is] the 'tidy -indent
-wrap' broken indentation even after setting the line wrap to 120
chars

>> $ git status
>> On branch master
>> Your branch is up to date with 'origin/master'.
>>
>> Changes not staged for commit:
>>   (use "git add <file>..." to update what will be committed)
>>   (use "git checkout -- <file>..." to discard changes in working
>> directory)
>>
>>         modified:   INSTALL
>>         modified:   README
>
> The two files above should be checked manually to
> make sure the changes are correct and necessary.

I changed the source so it'd be two short lines that would generate
correctly instead of a single long line that had to be fixed manually.
They look good now (at least to me)

>>         modified:   doc/webserver/developer-manual/coding.html
> [...]
>>         modified:   doc/webserver/user-manual/whatsnew.html
>
> Given that you changed the wrap length it makes sense
> that all those HTML files were modified.
>
> For extra credit you could separate the wrapping change
> from the FAQ edit change and commit them separately.

did :)

Lee


More information about the Privoxy-devel mailing list