[Privoxy-devel] atoi vs. parse_numeric_value

[Lee]

On 5/9/16, Ian Silvester <iansilvester at fastmail.fm> wrote:
> I'm honestly not too bothered either way. I don't retain the settings in
> mind and refer to documentation every time I need to change the
> settings. If it makes code cleaner then yes, I'm for the change.

I'm not too bothered either way either :)   It's just that a long time
ago I copied the LOG_LEVEL_xxx defines from errlog.h to config.txt &
now I don't have to do any hex conversions in my head.

Lee

>
> Ian
>
> My PGP public
> key[http://diem.serveftp.net:8080/IanSilvesterPGPPublicKey.asc]
>
> On Sat, 7 May 2016, at 14:16, Lee wrote:
>> Now that loadcfg.c has changed from
>> case hash_debug :
>>    config->debug |= atoi(arg);
>>
>> to
>> case hash_debug :
>>    config->debug |= parse_numeric_value(cmd, arg);
>>
>> anyone else like the idea of changing the privoxy config debug flags
>> to actually look like bit flags?
>>
>> $ grep "^debug " config.txt
>> debug  0x0001 # Log the destination for each request Privoxy let through.
>> debug  0x0002 # Show connection status
>> debug  0x0400 # Log the destination for requests Privoxy didn't let
>> through
>> debug  0x1000 # Startup banner and warnings
>> debug  0x2000 # Non-fatal errors
>> debug  0x4000 # Fatal errors
>>
>> Lee
>> _______________________________________________
>> Privoxy-devel mailing list
>> Privoxy-devel at lists.privoxy.org
>> https://lists.privoxy.org/mailman/listinfo/privoxy-devel
> _______________________________________________
> Privoxy-devel mailing list
> Privoxy-devel at lists.privoxy.org
> https://lists.privoxy.org/mailman/listinfo/privoxy-devel
>